Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide zlib and expat libs from the user of Poco libraries (replaces #4579) #4724

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Hide zlib and expat libs from the user of Poco libraries (replaces #4579) #4724

merged 4 commits into from
Oct 4, 2024

Commits on Oct 3, 2024

  1. foundation: Remove unused ucp.h 

    Nothing use this and it is not even included in Visual Studio project
files. Remove it so it will not confuse any more.
    @matejk
    Kari Argillander authored and matejk committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7287f68 View commit details
    Browse the repository at this point in the history

  2. foundation: Hide zlib from user 

    Hide zlib completly from user. This way we do not need to publish zlib.h
or zconfig.h.

As we now have two different pointer initalizing in constructor I choose
to use unique pointers so it is more obvious those are safe. I also
choose to use make_unique which default initalize z_stream_t. This makes
code more readable as we do not need to specifie every field of
z_stream_t. It really should not matter much if we initialize couple
field for nothing. If does we should add comment about that. Still
keeping _buffer without inializing as it is quite big.
    @matejk
    Kari Argillander authored and matejk committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b6148a2 View commit details
    Browse the repository at this point in the history

  3. xml: Hide expat and ParserEngine from user 

    Hide expat completly from user. This way we do not need to publish
expat.h or expat_external.h.

I move also headers to orignal locations so diff is smaller compared to
original.
    @matejk
    Kari Argillander authored and matejk committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    88308c2 View commit details
    Browse the repository at this point in the history

  4. chore(Foundation): Compression level constants

    @matejk
    matejk committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2e2a85a View commit details
    Browse the repository at this point in the history