Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ODBC): Poco:Data::ODBC - MSSQL (n)varchar(max) length issue #4324 #4738

Merged
merged 11 commits into from
Oct 19, 2024

Conversation

aleks-f
Copy link
Member

@aleks-f aleks-f commented Oct 15, 2024

No description provided.

@aleks-f aleks-f marked this pull request as ready for review October 16, 2024 10:26
@aleks-f aleks-f requested a review from matejk October 16, 2024 10:27
@aleks-f
Copy link
Member Author

aleks-f commented Oct 16, 2024

@aleks-f

  • add dynamic detection of the back end; indiscriminate use of SQLServer extensions obviously causes problems with other back ends:
    Requested SQL statement: INSERT INTO Person VALUES (?,?,?,?)
    Native SQL statement: INSERT INTO Person VALUES (?,?,?,?)
    : Connection:localhost:1521/XE
    Server:Not applicable
    ===========================
    ODBC Diagnostic record #1:
    ===========================
    SQLSTATE = 22001
    Native Error Code = 24152841
    [Devart][ODBC]String data, right-truncated
    

@cunj123

@matejk

  • cmake build
    equivalent of this

@cunj123
Copy link
Contributor

cunj123 commented Oct 17, 2024

@aleks-f the sql server odbc driver is already being installed in the odbc job https://github.com/pocoproject/poco/blob/4324-varchar-length/.github/workflows/ci.yml#L765

Copy link
Contributor

@matejk matejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem OK to me. I just have comments whether it shall be possible to configure MSSQL specialities in CMake also.

Data/ODBC/include/Poco/Data/ODBC/ODBC.h Outdated Show resolved Hide resolved
Data/ODBC/ODBC.make Show resolved Hide resolved
@aleks-f aleks-f self-assigned this Oct 19, 2024
@aleks-f aleks-f added this to the Release 1.14.0 milestone Oct 19, 2024
@aleks-f aleks-f merged commit 36c8082 into main Oct 19, 2024
44 checks passed
@aleks-f aleks-f deleted the 4324-varchar-length branch October 19, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants