-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Multiple Trigger Chars #7
base: master
Are you sure you want to change the base?
Conversation
triggerChar can now be set as just a char, or an array of chars. The trigger char is passed as the last parameter to the onDataRequest callback. All type and templates now include the type and trigger char.
Thanks for adding this. It could become quite powerful for tagging etc. The only thing is the usage of jQuery.data which I would prefer if we could avoid. Guess we need to change the signature of addMention to accept the triggerChar as a param? |
+1 for this. |
+1 |
1 similar comment
+1 |
I think there is no real nice way to circumvent the usage of data. |
Ehrm, I can't get triggerChar to work with an array - tried: Oh, this code isn't in the master branch yet - any way to access ryanramage's changes? |
@TorbenVesterager here is my fork: https://github.com/ryanramage/jquery-mentions-input . It is now a little out of date. You can try and merge all the this master branch in if you would like. |
Hi everyone, just stumbled upon this, and its is great however I am having some issues, I need to make different .getJSON() calls if a user types in an @ or an # can some create a GIST to show how to do this I am sure I am not the only one struggling |
How to add triggerChar from button click in mentionInput? triggerChar is not from type ahead. It comes from button click. |
Is multiple triggers working now? I mean "@" for mentions and "#" for hashtags, both from different JSON sources. |
@kockok I have the exact same question |
@kockok I have the exact same question² |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really amazing work. Love it.
triggerChar can now be set as just a char, or an array of chars. The trigger char is passed as the last parameter to the onDataRequest callback.
All type and templates now include the type and trigger char.
this commit fixes #5