fix(prisma): Too many idle db connections #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to prevent creation of many PrismaService instances
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
imilchev
approved these changes
Jun 20, 2024
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-api
that referenced
this pull request
Jun 21, 2024
* fix(prisma): Add prisma module Needed to prevent creation of many PrismaService instances * chore: Replace PersonService provider with PersonModule import
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-api
that referenced
this pull request
Jun 30, 2024
* fix(prisma): Add prisma module Needed to prevent creation of many PrismaService instances * chore: Replace PersonService provider with PersonModule import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a service through the provider interface of the module, NestJS creates new instance each time that provider service is referenced.
For example if we have 20 modules which have PrismaService as a provider, a 20 instances of PrismaService will be created, which could result in many idle db connections.
To fix this: