Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add create campaign agreements validation #649

Merged
merged 3 commits into from
Jun 25, 2024
Merged

add create campaign agreements validation #649

merged 3 commits into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. add create campaign agreements validation 

    if any of the 3 agreements for creating campaign are not checked -> throw a HttpException with status 405
    @Martbul
    Martbul committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8f0525a View commit details
    Browse the repository at this point in the history

  2. fix http error status code in campaign-application.service 

    http error code is now 400 in validation for all 3 agreements  in create method
    @Martbul
    Martbul committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    77c9df8 View commit details
    Browse the repository at this point in the history

  3. fix throw new BadRequestException 

    changed the error from HttpException to BadRequestException for the agreements validation in create method in campaign-application.service.ts
    @Martbul
    Martbul committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    139a6a9 View commit details
    Browse the repository at this point in the history