Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add findAll(GET) method in the campaign-application.service(second try) #652

Merged
merged 14 commits into from
Jul 1, 2024

Commits on Jun 25, 2024

  1. add create campaign agreements validation

    if any of the 3 agreements for creating campaign are not checked -> throw a HttpException with status 405
    Martbul committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8f0525a View commit details
    Browse the repository at this point in the history
  2. fix http error status code in campaign-application.service

    http error code is now 400 in validation for all 3 agreements  in create method
    Martbul committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    77c9df8 View commit details
    Browse the repository at this point in the history
  3. fix throw new BadRequestException

    changed the error from HttpException to BadRequestException for the agreements validation in create method in campaign-application.service.ts
    Martbul committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    139a6a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. injected prisma service

    Martbul committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    15ddce4 View commit details
    Browse the repository at this point in the history
  2. add findAll camapings method

    created findAll functionality in campaign-application.service and add testing for the method
    Martbul committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7d43335 View commit details
    Browse the repository at this point in the history
  3. reverted commit

    Martbul committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1280e2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    65dc547 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. fix test for findAll (campaign-applications) method

    new the mocked campaign-applications in the tests have the right schema(schema of the campaign-application)
    Martbul committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cb14fdf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fdbb75 View commit details
    Browse the repository at this point in the history
  3. Revert "fix test for findAll (campaign-applications) method"

    This reverts commit cb14fdf.
    Martbul committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6199f1d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bc0dd85 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a6d35fb View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. fix campaign-application controller and services

    remove unused providers in campaign-application.spec.ts
    add validation if user is admin in findAll method in campaign-application.controller.ts
    add tests for findAll method
    Martbul committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    480d492 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. remove commented code

    Martbul committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    e5488d3 View commit details
    Browse the repository at this point in the history