Email send task #665
Merged
Email send task #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when new campaign application is added the organizer will receive an email
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
requested changes
Sep 2, 2024
| @Injectable() | ||
| export class CampaignApplicationService { | ||
| private readonly bucketName: string = 'campaignapplication-files' | ||
| constructor( | ||
| private prisma: PrismaService, | ||
| private organizerService: OrganizerService, | ||
| private s3: S3Service, | ||
| private sendEmail: EmailService, |
There was a problem hiding this comment.
please rename to sendEmail to emailService
| person: Person, | ||
| ) { | ||
| const userEmail = { to: [person.email] as EmailData[] } | ||
| const adminEmail = { to: ['[email protected]'] as EmailData[] } |
There was a problem hiding this comment.
Would probably be better to put [email protected] into env, as it might be used in other places in the future. Something like CAMPAIGN_COORDINATOR_EMAIL would do I suppose
|
|
||
| await this.sendEmail.sendFromTemplate(mailAdmin, adminEmail, { | ||
| bypassUnsubscribeManagement: { enable: true }, | ||
| }) |
There was a problem hiding this comment.
I don't see any reason to await sending the emails, since they are not urgent for the response, and are allowed to happen with some delay. Though if there is any valid reason you can do it concurrently with Promise.allSettled, instead of doing it sequential, since neither of the promises are depended by the result of the another one.
Example:
const userEmailPromise = this.sendEmail.sendFromTemplate(mailOrganizer, userEmail, {
bypassUnsubscribeManagement: { enable: true },
})
const adminEmailPromise = this.sendEmail.sendFromTemplate(mailAdmin, adminEmail, {
bypassUnsubscribeManagement: { enable: true },
})
await Promise.allSettled([userEmailPromise, adminEmailPromise])…aignApplication method
sashko9807
force-pushed
the
emailSendTask
branch
from
df4319f
to
ab3dbdf
Compare
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.