Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted changes, moved objectFit prop into style prop in Image compo… #1542

Closed
wants to merge 1 commit into from

Conversation

Nkiriobasi
Copy link
Contributor

…nent

Closes #{issue number}

Motivation and context

Screenshots:

Before After
Paste screenshot Paste screenshot

Testing

Steps to test

Affected urls

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
dependency/name v1.0.0 v2.0.0

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 3, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 3, 2023
@igoychev
Copy link
Contributor

igoychev commented Aug 3, 2023

@Nkiriobasi it looks like this change is part of your first PR - could you push it to it, so that all changes are together?

@Nkiriobasi Nkiriobasi closed this Aug 3, 2023
@Nkiriobasi Nkiriobasi deleted the fix-issue branch August 3, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants