Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort donation wishes #1545

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Sort donation wishes #1545

merged 3 commits into from
Aug 10, 2023

Conversation

tongo-angelov
Copy link
Contributor

Allow users to sort donation wishes by date or donation amount

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 7, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 7, 2023
@slavcho
Copy link
Contributor

slavcho commented Aug 8, 2023

Can you add some screenshots?

Copy link
Contributor

@slavcho slavcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.
But I'd like to see some screenshots.
Do we have a ticket for this change?

setSearchValue(event.target.value)
}

const debounceSearch = useMemo(() => debounce(handleSearch, 300), [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@tongo-angelov
Copy link
Contributor Author

I'm sorry, here are some screenshots.

Sort by donation amount:
Screenshot 2023-08-08 at 8 31 54

Search:
Screenshot 2023-08-08 at 8 32 18

Search with no results:
Screenshot 2023-08-08 at 8 32 28

@igoychev
Copy link
Contributor

igoychev commented Aug 8, 2023

Do we have a ticket for this change?

Yep, @slavcho here it is: #1429
@tongo-angelov for next PR please use the PR template

@slavcho
Copy link
Contributor

slavcho commented Aug 8, 2023

Great, I would only change "Сортирай" with "Сортирай по".

I'm sorry, here are some screenshots.

Sort by donation amount: Screenshot 2023-08-08 at 8 31 54

Search: Screenshot 2023-08-08 at 8 32 18

Search with no results: ![Screenshot 2023-08-08 at 8 32 28](https://user-images.githubusercontent.com/123360440/258993904-ebe403fb-12db-4698-951d-890e4dd3262f.

@ani-kalpachka
Copy link
Member

Is this related to #1399 or #1429?
I think the two tickets are duplicated.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 9, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 9, 2023
@igoychev igoychev merged commit 98a0f38 into podkrepi-bg:master Aug 10, 2023
11 of 12 checks passed
@tongo-angelov tongo-angelov deleted the sort-wishes branch August 10, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants