fix: disable source editor to avoid SWC bug #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
github-actions
bot
removed
the
run tests
ani-kalpachka
approved these changes
Aug 31, 2023
|
closing as it was fixed by updating next as per your recomendation in this PR: #1576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to swc-project/swc#7640, the editor fails in production. The change here removes the plugin that causes the error.
There are two other alternatives:
Given the non-technical audience, I think that disabling the diff/source feature is the best option. Let me know if you think otherwise, though.