Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added campaign expenses chart #1605

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

tongo-angelov
Copy link
Contributor

Added stacked bar chart to show expenses, grouped by expense type and sorted large to small.
The bar max value is set to the campaign reached amount.

Issue #1556

Screenshots:

Before:
Screenshot from 2023-09-23 23-51-44

After:
Screenshot from 2023-09-23 23-52-14

New or updated dependencies:

"chart.js": "^4.4.0",
"react-chartjs-2": "^5.2.0"

@tongo-angelov tongo-angelov marked this pull request as ready for review September 23, 2023 20:59
@github-actions
Copy link

github-actions bot commented Sep 23, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

@tongo-angelov
Copy link
Contributor Author

Added labels to the chart

Screenshots:

Screenshot from 2023-09-25 12-34-42

New dependencies:

"chartjs-plugin-datalabels": "^2.2.0"

Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!
merging and further improvements and feedback will be done separately

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Sep 25, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 25, 2023
@igoychev igoychev merged commit 363a42f into podkrepi-bg:master Sep 25, 2023
11 of 12 checks passed
@tongo-angelov tongo-angelov deleted the expenses-chart branch September 25, 2023 17:51
@yoanamanolova
Copy link

@tongo-angelov, based on Mariana’s feedback, the change was conditionally approved, requesting to add “available funds” next to reconciled and budgeted expenses. Available funds= budgeted - reconciled Налична сума= събрана - отчетена

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants