Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign fixes #1773

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

sashko9807
Copy link
Member

Closes #{issue number}

Motivation and context

Screenshots:

Before After
Paste screenshot Paste screenshot

Testing

Steps to test

Affected urls

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
'isomorphic-dompurify` `2.7.0 Allows to use DOMPurify on serverside

Needed by the campaign team, until we figure out how to translate the campaign text
…cription

The Quill editor shows incosistency when reading the data(adds unnecessary spaces, breaks formating etc.)
Copy link

❌ Not all tests have run for this PR. Please add the run tests label to trigger them.

@slavcho
Copy link
Contributor

slavcho commented Apr 26, 2024

@sashko9807 Is this pending on something?
Seems like this fix would be very useful for the campaign team.

@sashko9807
Copy link
Member Author

@sashko9807 Is this pending on something?
Seems like this fix would be very useful for the campaign team.

Dropping React Quill for reading markdown text, might be breaking the formating of current campaigns, thus I need some time to manually test that everything is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants