Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust locale button style on hover #1972

Merged

Conversation

katina-anachkova
Copy link
Contributor

Closes #1909

Motivation and context

Styling of the Locale button in the navigation not adjusted for mobile version - it is the same as the desktop version, while the other tabs` styles differentiate.

Styles of all MobileNav list items must be unified.

To solve that, i added sx property on the Locale button to style it for breakpoints below 900px

Screenshots:

Before After
image image

Testing

Steps to test

  1. Resize the window to width below 900px, which is the breakpoint where the navigation switches mobile/desktop.
  2. Hover over the Locale button - it should have the blue color that appears on hovering register/login buttons and transparent background.
  3. The new style shouldn't affect the button with breakpoints above 900px.

Copy link

github-actions bot commented Nov 5, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@slavcho slavcho added the run tests Allows running the tests workflows for forked repos label Nov 5, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Nov 5, 2024
@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Nov 8, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Nov 8, 2024
@ani-kalpachka ani-kalpachka merged commit 8cebae2 into podkrepi-bg:master Nov 8, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange size of shadow on button for change language
3 participants