Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Convert SSOP-10_3.9x4.9mm_P1.00mm to generator, and add SOP-10_3.9x4.9mm_P1mm and NSOP-16_3.9x9.9mm_P1.27mm #645

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thatoddmailbox
Copy link

This PR converts the existing SSOP-10_3.9x4.9mm_P1.00mm footprint to be automatically generated. (the name is overridden, so that it stays as P1.00mm rather than P1mm for compatibility).

This also adds some duplicate symbols:

  • Package_SO:SSOP-10_3.9x4.9mm_P1.00mm -> Package_SO:SOP-10_3.9x4.9mm_P1mm
  • Package_SO:SOIC-16_3.9x9.9mm_P1.27mm -> Package_SO:NSOP-16_3.9x9.9mm_P1.27mm

(See KiCad/kicad-footprints#2432 for explanation/justification)

…9mm_P1.00mm and NSOP-16_3.9x9.9mm_P1.27mm

see KiCad/kicad-footprints#2432 for explanation
@codeclimate
Copy link

codeclimate bot commented Sep 29, 2020

Code Climate has analyzed commit 67c6c67 and detected 0 issues on this pull request.

View more on Code Climate.

@thatoddmailbox
Copy link
Author

I also found that I had to edit the other entries in soic.yaml to use {pincount:s} instead of {pincount:d}, due to the changes in commit 738ff16. (it's a string now instead of a number)

@@ -432,7 +432,7 @@ SOIC-8_7.5x5.85mm_P1.27mm:

SOIC-14_3.9x8.7mm_P1.27mm:
#round to two significant digits to comply with old name
custom_name_format: SOIC-{pincount:d}_{size_x:.2g}x{size_y:.2g}mm_P{pitch:g}mm
custom_name_format: SOIC-{pincount:s}_{size_x:.2g}x{size_y:.2g}mm_P{pitch:g}mm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change all of those?
edit: I see that you commented on that. My first guess is that this is an unintended changed in the generator.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can undo this change if you want, but then the script crashes on generating soic.yaml.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: We are discussing this issue in #649

Comment on lines 205 to 209
minimum: 3.80
maximum: 4.00
body_size_y:
minimum: 4.80
maximum: 5.00
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get the min-max values from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't realize you were able to just write exact values! These don't have tolerances, so I changed them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants