Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Discord #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robdy
Copy link
Member

@robdy robdy commented Nov 29, 2018

I played with discord.js a bit and that's the result. It's not yet ready but in case you see any areas for improvement, feel free to let me know.

Features:

  • Sending messages to both IRC and Discord
  • Processing messages from Discord
  • Adding rich embed to all applicable commands (would appreciate any help here) - if we don't use richText, default one will be used
  • Correct eslint errors
  • Maybe rewrite the code so that outputResponse takes target and messages where messages is object with text and richText inside

@robdy robdy force-pushed the add-discord branch 2 times, most recently from 55c1534 to f668f7f Compare November 29, 2018 20:23
@@ -3,5 +3,8 @@ module.exports = {
message_regex: /^\.lenny/,
response: function () {
return "( ͡° ͜ʖ ͡°)‎";
}
},
richResponse: function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how much I'm going to fight this because I disagree with the underlying way of doing this, and I'm not sure I want to bother, but you should probably get it to just use response if there is no richResponse rather than duplicating this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're totally right, that was just something which I added for testing and forgot to remove. But obviously there's no point to duplicate the same response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants