Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition before the variables are made where the update function runs before the rest of the code is initialized.
![image](https://private-user-images.githubusercontent.com/69512353/284258605-5caf2855-6ceb-4c6f-aeff-cea6d591d051.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTQ4MzYsIm5iZiI6MTczOTQ5NDUzNiwicGF0aCI6Ii82OTUxMjM1My8yODQyNTg2MDUtNWNhZjI4NTUtNmNlYi00YzZmLWFlZmYtY2VhNmQ1OTFkMDUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDAwNTUzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlMDA4ZGI5MTZhNmE2NmZmNjE0ODIzYWVhMGY3Y2I0NGMwNTIwZGM1NDdiMzY2YzY5YWZiMDczOWIyMDYwMDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.5sgbNX-eKjZxKz3gIbrmdcu0PMdknuHpXC_8SDHspdU)
First, yes, here is proof of the crash.
Second, CustomFPC is not the reason, this is the code for CustomFPC, it calls super().__init__() which runs FirstPersonController's __init__ function and the rest is handled by FirstPersonController.
Last, if setting the self.enabled to False also works, its better to do that, I just couldn't replicate this race condition to test that.