-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Session Error handling and caching #26
Merged
nodiesBlade
merged 23 commits into
main
from
enhancement/unassigned/get-session-improvement
Mar 30, 2024
Merged
Enhancement: Session Error handling and caching #26
nodiesBlade
merged 23 commits into
main
from
enhancement/unassigned/get-session-improvement
Mar 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodiesBlade
changed the title
Enhancement/unassigned/get session improvement
Enhancement: Session Error handling and caching
Mar 28, 2024
…qos node endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue
N/A
Description
Occasionally during session rollover, dispatcher nodes will be syncing up to the latest session. During this time, gateway server would request for a specific sesssion, however the dispatcher (due to Pocket core code) will return the old session. This is an issue because Gateway server caches sessions, under the assumption that when requesting a specific session, then the dispatcher will return the proper session.
Example:
In order to fix this, we add a explicit error check that compares the requested session with the returned session. If there is a mismatch, we return an error in our basic_client implementation.
Other misc changes:
Type of change
Please delete option that is not relevant.
Related PRs
List related PRs below