Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Supplier] Add missing event #872

Open
wants to merge 277 commits into
base: main
Choose a base branch
from
Open

Conversation

bryanchriswhite
Copy link
Contributor

Summary

  • Add EventSupplierUnbondingCanceled when a supplier is re-staked during its unbonding period.
  • Improve supplier (un/)staking unit tests by adding event assertions.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

bryanchriswhite and others added 30 commits September 27, 2024 11:47
Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Redouane Lakrache <[email protected]>
…e-param' into issues/612/param/min-stake-gateway

* pokt/issues/612/chore/gateway-msg-update-param:
  chore: review feedback improvements
  [Docs] Update README(s) (#842)
…eway/logic

* issues/612/param/min-stake-gateway:
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs] Update README(s) (#842)
…eway/logic

* issues/612/param/min-stake-gateway:
  fix: test error message
…ake-gateway

* pokt/main:
  [Gateway] chore: add `MsgUpdateParam` to gateway module (#808)
…ation/min-stake-param

* issues/612/app/msg-update-param:
  fix: linter errors
  chore: review feedback improvements

# Conflicts:
#	x/application/keeper/msg_server_update_param.go
…e-param

* issues/612/gateway/logic:
  fix: test error message
  chore: review feedback improvements
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs] Update README(s) (#842)
…ation/min-stake-param

* issues/612/app/msg-update-param:
  fix: test error message
  chore: review feedback improvements
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs] Update README(s) (#842)
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 872)
Grafana network dashboard for devnet-issue-872

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Oct 21, 2024
@bryanchriswhite bryanchriswhite marked this pull request as ready for review October 21, 2024 08:39
@bryanchriswhite bryanchriswhite added push-image CI related - pushes images to ghcr.io devnet-test-e2e and removed push-image CI related - pushes images to ghcr.io devnet-test-e2e devnet labels Oct 21, 2024
Copy link

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 872)
Grafana network dashboard for devnet-issue-872

@bryanchriswhite bryanchriswhite changed the base branch from issues/858/events/gateway to main October 23, 2024 13:38
@bryanchriswhite bryanchriswhite linked an issue Oct 23, 2024 that may be closed by this pull request
5 tasks
Copy link

gitguardian bot commented Oct 24, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12819930 Triggered Generic Password 6ff6a8a localnet/kubernetes/values-pocketdex-postgres.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e on-chain On-chain business logic push-image CI related - pushes images to ghcr.io supplier Changes related to the Supplier actor
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

[Events] Add missing events
3 participants