[LocalNet] Add Path to LocalNet #879
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
gateway
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 14114212 | Triggered | Generic High Entropy Secret | 1cba315 | localnet/kubernetes/values-path.yaml | View secret |
| 14114212 | Triggered | Generic High Entropy Secret | 1e7896b | localnet/kubernetes/path-config.yaml | View secret |
| 14114212 | Triggered | Generic High Entropy Secret | baa627f | localnet/kubernetes/path-config-3.yaml | View secret |
| 14114212 | Triggered | Generic High Entropy Secret | baa627f | localnet/kubernetes/path-config-2.yaml | View secret |
| 14114212 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-2.yaml | View secret |
| 14150880 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-3.yaml | View secret |
| 14150881 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-2.yaml | View secret |
| 14114212 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-3.yaml | View secret |
| 13506804 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-1.yaml | View secret |
| 14114212 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-1.yaml | View secret |
| 13506804 | Triggered | Generic High Entropy Secret | f0b204a | localnet/kubernetes/path-config-1.yaml | View secret |
| 13506804 | Triggered | Generic High Entropy Secret | 5b57e3e | localnet/kubernetes/path-config-1.yaml | View secret |
| 14150881 | Triggered | Generic High Entropy Secret | 5b57e3e | localnet/kubernetes/path-config-2.yaml | View secret |
| 14150880 | Triggered | Generic High Entropy Secret | 5b57e3e | localnet/kubernetes/path-config-3.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
red-0ne
force-pushed
the
feat/localnet-path
branch
from
9426695
to
92a8e4e
Compare
Olshansk
reviewed
Oct 16, 2024
config.yml
Outdated
| service_configs: | ||
| - service_id: anvil | ||
| - service_id: "0021" |
There was a problem hiding this comment.
tl;dr I'm changing this back
I understand why you did this, but:
- This is legacy from Morse adopted into PATH
- I'd rather change PATH and move forward
- If we make this change, you'll need to change a lot more (see the search result below)
- This requires a TODO_IN_THIS_PR
There was a problem hiding this comment.
From my understanding, Path does not know about / have "anvil" as an EVM service.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -463,7 +469,9 @@ func (s *suite) TheApplicationSendsTheSupplierASuccessfulRequestForServiceWithPa | |||
| method = "GET" | |||
| } | |||
|
|
|||
| res, err := s.pocketd.RunCurlWithRetry(appGateServerUrl, serviceId, method, path, requestData, 5) | |||
| // TODO_IN_THIS_PR: Figure out a plan for deprecating appGateServerUrl in a followup (cleaner) PR | |||
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Figure out a plan for deprecating appGateServerUrl in a followup (cleaner) PR
| # Build the Docker image with Tilt (local build) | ||
| docker_build("path-gateway-local", path_local_repo) | ||
|
|
||
| # TODO_IN_THIS_PR(@okdas): Move configs to values and add helm charts for PATH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Path to Tilt so it could run on LocalNet for E2E tests and local load testing.
Issue
In order to deprecate AppGate server and have better integration with the production gateway component, Path needs to run on LocalNet for both E2E test and load testing.
AppGateServertoPATH#838Type of change
Testing
make test_e2edevnet-test-e2elabel to the PR.Sanity Checklist