-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LocalNet] Add Path to LocalNet #879
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14114212 | Triggered | Generic High Entropy Secret | 1cba315 | localnet/kubernetes/values-path.yaml | View secret |
14114212 | Triggered | Generic High Entropy Secret | 1e7896b | localnet/kubernetes/path-config.yaml | View secret |
14114212 | Triggered | Generic High Entropy Secret | baa627f | localnet/kubernetes/path-config-3.yaml | View secret |
14114212 | Triggered | Generic High Entropy Secret | baa627f | localnet/kubernetes/path-config-2.yaml | View secret |
14114212 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-2.yaml | View secret |
14150880 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-3.yaml | View secret |
14150881 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-2.yaml | View secret |
14114212 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-3.yaml | View secret |
13506804 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-1.yaml | View secret |
14114212 | Triggered | Generic High Entropy Secret | b82ad3d | localnet/kubernetes/path-config-1.yaml | View secret |
13506804 | Triggered | Generic High Entropy Secret | f0b204a | localnet/kubernetes/path-config-1.yaml | View secret |
13506804 | Triggered | Generic High Entropy Secret | 5b57e3e | localnet/kubernetes/path-config-1.yaml | View secret |
14150881 | Triggered | Generic High Entropy Secret | 5b57e3e | localnet/kubernetes/path-config-2.yaml | View secret |
14150880 | Triggered | Generic High Entropy Secret | 5b57e3e | localnet/kubernetes/path-config-3.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
9426695
to
92a8e4e
Compare
config.yml
Outdated
service_configs: | ||
- service_id: anvil | ||
- service_id: "0021" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, Path does not know about / have "anvil" as an EVM
service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it. PR incoming soon.
@@ -463,7 +469,9 @@ func (s *suite) TheApplicationSendsTheSupplierASuccessfulRequestForServiceWithPa | |||
method = "GET" | |||
} | |||
|
|||
res, err := s.pocketd.RunCurlWithRetry(appGateServerUrl, serviceId, method, path, requestData, 5) | |||
// TODO_IN_THIS_PR: Figure out a plan for deprecating appGateServerUrl in a followup (cleaner) PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Figure out a plan for deprecating appGateServerUrl in a followup (cleaner) PR
# Build the Docker image with Tilt (local build) | ||
docker_build("path-gateway-local", path_local_repo) | ||
|
||
# TODO_IN_THIS_PR(@okdas): Move configs to values and add helm charts for PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@red-0ne Didn't review this, but putting a "cod review" checkpoint to reference when this is ready.
Summary
Add Path to Tilt so it could run on LocalNet for E2E tests and local load testing.
Issue
In order to deprecate AppGate server and have better integration with the production gateway component, Path needs to run on LocalNet for both E2E test and load testing.
AppGateServer
toPATH
#838Type of change
Testing
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist