Skip to content

Commit

Permalink
un-skipping gather test
Browse files Browse the repository at this point in the history
  • Loading branch information
Bidek56 committed Jul 7, 2024
1 parent 7980f50 commit 73e12ee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion __tests__/expr.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ describe("expr", () => {
const actual = df.select(col("a").tail(3).as("tail3"));
expect(actual).toFrameEqual(expected);
});
test.skip("take", () => {
test("take", () => {
const df = pl.DataFrame({ a: [1, 2, 2, 3, 3, 8, null, 1] });
const expected = pl.DataFrame({
"take:array": [1, 2, 3, 8],
Expand Down
2 changes: 1 addition & 1 deletion src/lazy/dsl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ impl JsExpr {
}
#[napi(catch_unwind)]
pub fn gather(&self, idx: &JsExpr) -> JsExpr {
self.clone().inner.gather(idx.inner.clone()).into()
self.clone().inner.gather(idx.inner.clone().cast(DataType::Int64)).into()
}
#[napi(catch_unwind)]
pub fn sort_by(&self, by: Vec<&JsExpr>, reverse: Vec<bool>) -> JsExpr {
Expand Down

0 comments on commit 73e12ee

Please sign in to comment.