Skip to content

Commit

Permalink
Add to LazyDF javascript
Browse files Browse the repository at this point in the history
Previously defaulted to true (does not match rust defaults)
  • Loading branch information
davidgovea committed Jun 21, 2024
1 parent 6c80dc8 commit cbdf848
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions polars/lazy/dataframe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -399,11 +399,13 @@ export interface LazyDataFrame extends Serialize, GroupByOps<LazyGroupBy> {
sort(
by: ColumnsOrExpr,
descending?: ValueOrArray<boolean>,
nulls_last?: boolean,
maintain_order?: boolean,
): LazyDataFrame;
sort(opts: {
by: ColumnsOrExpr;
descending?: ValueOrArray<boolean>;
nulls_last?: boolean;
maintain_order?: boolean;
}): LazyDataFrame;
/**
Expand Down Expand Up @@ -957,15 +959,20 @@ export const _LazyDataFrame = (_ldf: any): LazyDataFrame => {
}
return _LazyDataFrame(_ldf.slice(opt, len));
},
sort(arg, descending = false, maintain_order = false) {
sort(arg, descending = false, nulls_last = false, maintain_order = false) {
if (arg?.by !== undefined) {
return this.sort(arg.by, arg.descending, arg.maintain_order);
return this.sort(
arg.by,
arg.descending,
arg.nulls_last,
arg.maintain_order,
);
}
if (typeof arg === "string") {
return wrap("sort", arg, descending, true, maintain_order);
return wrap("sort", arg, descending, nulls_last, maintain_order);
}
const by = selectionToExprList(arg, false);
return wrap("sortByExprs", by, descending, true, maintain_order);
return wrap("sortByExprs", by, descending, nulls_last, maintain_order);
},
std() {
return _LazyDataFrame(_ldf.std());
Expand Down

0 comments on commit cbdf848

Please sign in to comment.