-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using rs-0.40 #211
Using rs-0.40 #211
Conversation
Co-authored-by: Cory Grinstead <[email protected]>
@universalmind303 Do you have any ideas on this |
.yarnrc.yml
Outdated
compressionLevel: mixed | ||
|
||
yarnPath: .yarn/releases/yarn-3.6.1.cjs | ||
enableGlobalCache: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were using a local yarn file which did not match the yarn version from package.json
Apparently Node corepack
is the new way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd prefer to not change the yarnrc in this PR.
AFAICT, the current implementation works fine with corepack
> corepack enable
> yarn
> yarn build:debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want a separate PR for corepack
?
The current implementation work fine due to this file but that's out of sync with what's in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just go with this.
compressionLevel: mixed
enableGlobalCache: false
nodeLinker: node-modules
the main thing I wanted to avoid was using yarn's linker as it makes things more difficult for contributors.
Updating to use base rs-0.40 release