Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using rs-0.40 #211

Merged
merged 11 commits into from
Jun 3, 2024
Merged

Using rs-0.40 #211

merged 11 commits into from
Jun 3, 2024

Conversation

Bidek56
Copy link
Collaborator

@Bidek56 Bidek56 commented May 23, 2024

Updating to use base rs-0.40 release

@Bidek56 Bidek56 self-assigned this May 23, 2024
@Bidek56 Bidek56 added the enhancement New feature or request label May 23, 2024
__tests__/dataframe.test.ts Show resolved Hide resolved
src/conversion.rs Outdated Show resolved Hide resolved
src/dataframe.rs Outdated Show resolved Hide resolved
src/dataframe.rs Outdated Show resolved Hide resolved
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
src/dataframe.rs Outdated Show resolved Hide resolved
Co-authored-by: Cory Grinstead <[email protected]>
@Bidek56
Copy link
Collaborator Author

Bidek56 commented May 24, 2024

@universalmind303 Do you have any ideas on this gather test? Thx

@Bidek56 Bidek56 changed the title Updating to use rs-0.40 Using rs-0.40 May 24, 2024
.yarnrc.yml Outdated
Comment on lines 1 to 3
compressionLevel: mixed

yarnPath: .yarn/releases/yarn-3.6.1.cjs
enableGlobalCache: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for?

Copy link
Collaborator Author

@Bidek56 Bidek56 May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using a local yarn file which did not match the yarn version from package.json
Apparently Node corepack is the new way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd prefer to not change the yarnrc in this PR.

AFAICT, the current implementation works fine with corepack

> corepack enable
> yarn
> yarn build:debug

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want a separate PR for corepack?
The current implementation work fine due to this file but that's out of sync with what's in package.json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just go with this.

compressionLevel: mixed
enableGlobalCache: false
nodeLinker: node-modules

the main thing I wanted to avoid was using yarn's linker as it makes things more difficult for contributors.

@universalmind303 universalmind303 merged commit 9a65b9d into pola-rs:main Jun 3, 2024
9 checks passed
@Bidek56 Bidek56 deleted the rs-0.40 branch June 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants