docs(python): simplify/clarify group_by_dynamic examples #11335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
stinodego
reviewed
Sep 26, 2023
MarcoGorelli
requested review from
ritchie46 and
alexander-beedie
as code owners
MarcoGorelli
commented
Sep 27, 2023
stinodego
approved these changes
Sep 27, 2023
romanovacca
pushed a commit
to romanovacca/polars
that referenced
this pull request
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest I think the current examples are bit too complicated - they can be simplified to (hopefully better) get the point across
The rows are already kind of numbered by
'n', by just aggregating bypl.col('n')it becomes clear which row belongs to which windowAnd it's now easier to read without datetimes all of the place