Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set up CodSpeed #15537

Merged
merged 10 commits into from
Apr 8, 2024
Merged

ci: Set up CodSpeed #15537

merged 10 commits into from
Apr 8, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Apr 8, 2024

Ref #15531

Changes

  • Refactor the H2O AI benchmark script into a pytest setup that works with CodSpeed
  • Update R to the latest version - this slightly changes the generated dataset, so some of the test values had to be adjusted

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (cb5dd44) to head (8e5b264).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15537      +/-   ##
==========================================
+ Coverage   81.13%   81.17%   +0.04%     
==========================================
  Files        1363     1367       +4     
  Lines      175161   175307     +146     
  Branches     2527     2527              
==========================================
+ Hits       142112   142313     +201     
+ Misses      32573    32518      -55     
  Partials      476      476              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 8, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 22 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_filter1 (1.2 s)
  • test_filter2 (2 s)
  • test_h2oai_groupby_q1 (6.5 s)
  • test_h2oai_groupby_q10 (40.3 s)
  • test_h2oai_groupby_q2 (12.8 s)
  • test_h2oai_groupby_q3 (8.9 s)
  • test_h2oai_groupby_q4 (5.7 s)
  • test_h2oai_groupby_q5 (7.2 s)
  • test_h2oai_groupby_q6 (14.1 s)
  • test_h2oai_groupby_q7 (8.5 s)
  • test_h2oai_groupby_q8 (9.3 s)
  • test_h2oai_groupby_q9 (13.7 s)
  • test_boolean_min_max_agg (15.7 ms)
  • test_categorical_vs_str_group_by (14.3 ms)
  • test_cross_join (6 ms)
  • test_cross_join_slice_pushdown (4.6 ms)
  • test_max_statistic_parquet_writer (299.8 ms)
  • test_mean_overflow (1.8 s)
  • test_min_max_2850 (10.4 ms)
  • test_read_scan_large_csv (123.8 s)
  • test_sort_nan_1942 (1 ms)
  • test_windows_not_cached (3.5 s)

@stinodego stinodego marked this pull request as ready for review April 8, 2024 20:54
@stinodego stinodego merged commit 44f1097 into main Apr 8, 2024
16 checks passed
@stinodego stinodego deleted the codspeed branch April 8, 2024 21:01
@c-peters c-peters added the accepted Ready for implementation label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants