Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust!): Move schema resolving to IR phase. #15714

Merged
merged 16 commits into from
Apr 18, 2024
Merged

refactor(rust!): Move schema resolving to IR phase. #15714

merged 16 commits into from
Apr 18, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Apr 17, 2024

This will allow us to evaluate plans server-side. E.g. on a locations where the schema will be resolved.

@ritchie46 ritchie46 changed the title Schema WIP: move schema resolving to IR phase. Apr 17, 2024
@ritchie46 ritchie46 changed the title WIP: move schema resolving to IR phase. refactor(rust!): Move schema resolving to IR phase. Apr 17, 2024
@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars labels Apr 17, 2024
Copy link

codspeed-hq bot commented Apr 17, 2024

CodSpeed Performance Report

Merging #15714 will not alter performance

Comparing schema (6267a88) with main (2db0ba6)

Summary

✅ 22 untouched benchmarks

@ritchie46
Copy link
Member Author

todo: cache rename schema
add (cached lp_arena, expr_arena, lp_top) node.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 93.59268% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (2db0ba6) to head (d50753e).

❗ Current head d50753e differs from pull request most recent head 6267a88. Consider uploading reports for the commit 6267a88 to get more accurate results

Files Patch % Lines
...ates/polars-plan/src/logical_plan/functions/dsl.rs 76.27% 14 Missing ⚠️
crates/polars-plan/src/logical_plan/schema.rs 62.50% 6 Missing ⚠️
...src/logical_plan/conversion/dsl_plan_to_ir_plan.rs 97.19% 5 Missing ⚠️
crates/polars-plan/src/dot.rs 0.00% 1 Missing ⚠️
crates/polars-plan/src/logical_plan/builder_dsl.rs 96.29% 1 Missing ⚠️
...tes/polars-plan/src/logical_plan/conversion/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15714      +/-   ##
==========================================
- Coverage   81.35%   81.34%   -0.01%     
==========================================
  Files        1377     1378       +1     
  Lines      176613   176515      -98     
  Branches     2544     2544              
==========================================
- Hits       143676   143584      -92     
+ Misses      32456    32449       -7     
- Partials      481      482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8454d9c into main Apr 18, 2024
27 checks passed
@ritchie46 ritchie46 deleted the schema branch April 18, 2024 07:35
@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants