Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Handle non-Sequence iterables in filter #16254

Merged
merged 7 commits into from
May 22, 2024
Merged

fix(python): Handle non-Sequence iterables in filter #16254

merged 7 commits into from
May 22, 2024

Commits on May 22, 2024

  1. fix(python): Handle non-Sequence iterables in filter

    @dangotbanned
    dangotbanned committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6124171 View commit details
    Browse the repository at this point in the history

  2. test(python): Check for aligned behaviour in Sequence/Iterable pr… 

    …edicate
    @dangotbanned
    dangotbanned committed May 22, 2024
    Configuration menu
    Copy the full SHA
    882a5e6 View commit details
    Browse the repository at this point in the history

  3. fix(python): Satisfy mypy unknown arg-type

    @dangotbanned
    dangotbanned committed May 22, 2024
    Configuration menu
    Copy the full SHA
    498fbc4 View commit details
    Browse the repository at this point in the history

  4. fix(python): Ignore arg-type

    @dangotbanned
    dangotbanned committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6de9851 View commit details
    Browse the repository at this point in the history

  5. fix(python): maintain typing for _is_generator

    @dangotbanned
    dangotbanned committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4fc6a1b View commit details
    Browse the repository at this point in the history

  6. fix(python): remove unused ignore arg-type

    @dangotbanned
    dangotbanned committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1c5ebd9 View commit details
    Browse the repository at this point in the history

  7. test(python): Improve coverage with extra predicate cases 

    Adapted from @alexander-beedie on [discord](https://discord.com/channels/908022250106667068/908022461751234570/1242428077955354684).

I added 2 non-expression cases for the boolean masks.
    @dangotbanned
    dangotbanned committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4bfd044 View commit details
    Browse the repository at this point in the history