Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): Fix panic when computing min() of Duration series. #16455

Merged
merged 1 commit into from
May 24, 2024
Merged

fix(rust): Fix panic when computing min() of Duration series. #16455

merged 1 commit into from
May 24, 2024

Conversation

BGR360
Copy link
Contributor

@BGR360 BGR360 commented May 23, 2024 •
edited
Loading

The implementation of min_reduce accidentally called .as_duration() twice. The second one panicked because the AnyType was no longer Int64.

Fixes #16382

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels May 23, 2024
ritchie46
ritchie46 approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ritchie46 ritchie46 merged commit 05c2f87 into pola-rs:main May 24, 2024
28 checks passed
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@BGR360 @Wouittone
fix(rust): Fix panic when computing min() of Duration series. (pola-r…
a60861e 
…s#16455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

min fails on duration types
2 participants
@BGR360 @ritchie46