Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Add polars.pyd to .gitignore #16571

Closed
wants to merge 1 commit into from

Conversation

KDruzhkin
Copy link
Contributor

The file 'py-polars\polars\polars.pyd' is created on Windows. It is basically a DLL.

See Python on Windows FAQ — Is a *.pyd file the same as a DLL?

The file 'py-polars\polars\polars.pyd' is created on Windows.
It is basically a DLL.

See [https://docs.python.org/3/faq/windows.html#is-a-pyd-file-the-same-as-a-dll].
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 29, 2024
@KDruzhkin KDruzhkin changed the title chore: Add polars.pyd to .gitignore chore(python): Add polars.pyd to .gitignore May 29, 2024
@stinodego
Copy link
Member

stinodego commented May 29, 2024

Hey, thanks for the PR.

The file 'py-polars\polars\polars.pyd' is created on Windows.

When is it created? I've built Polars on Windows before and never seen this file.

@KDruzhkin
Copy link
Contributor Author

When is it created? I've built Polars on Windows before and never seen this file.

#16572 (comment)

@KDruzhkin
Copy link
Contributor Author

There is a template ”.gitignore“ by GitHub for Python projects. It has *.py[cod].
(IIRC, *.pyc and *.pyo files sit under __pycache__ which is already ignored).

https://github.com/github/gitignore/blob/main/Python.gitignore

@squnit
Copy link
Contributor

squnit commented Sep 11, 2024

Closed by #18498

@KDruzhkin KDruzhkin closed this Sep 11, 2024
@KDruzhkin KDruzhkin deleted the gitignore_pyd branch September 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants