-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust): Parallel linearize in new streaming engine #17050
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17050 +/- ##
==========================================
- Coverage 80.95% 80.86% -0.10%
==========================================
Files 1448 1457 +9
Lines 190554 191042 +488
Branches 2723 2723
==========================================
+ Hits 154265 154487 +222
- Misses 35786 36051 +265
- Partials 503 504 +1 ☔ View full report in Codecov by Sentry. |
|
||
// The morsel sequence id which comes after this morsel. | ||
pub fn successor(self) -> Self { | ||
Self(self.0.checked_add(2).unwrap()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a comment why we have increments of 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what the comment on new
is for, the idea is to indicate the 'last morsel with this sequence id' using the final bit, so the sequence 1, 2, 3, 3, 3, 4 can become 2, 4, 6, 6, 7, 8 and as soon as we see 7 we know there won't be any 6s or 7s anymore.
No description provided.