Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Parallel linearize in new streaming engine #17050

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jun 18, 2024

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 2.60870% with 112 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (8a410ca) to head (0d612cc).
Report is 67 commits behind head on main.

Current head 0d612cc differs from pull request most recent head c30937a

Please upload reports for the commit c30937a to get more accurate results.

Files Patch % Lines
...tes/polars-stream/src/utils/in_memory_linearize.rs 0.00% 85 Missing ⚠️
crates/polars-utils/src/priority.rs 0.00% 9 Missing ⚠️
crates/polars-stream/src/morsel.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/nodes/filter.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/nodes/in_memory_sink.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17050      +/-   ##
==========================================
- Coverage   80.95%   80.86%   -0.10%     
==========================================
  Files        1448     1457       +9     
  Lines      190554   191042     +488     
  Branches     2723     2723              
==========================================
+ Hits       154265   154487     +222     
- Misses      35786    36051     +265     
- Partials      503      504       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/polars-stream/src/morsel.rs Show resolved Hide resolved

// The morsel sequence id which comes after this morsel.
pub fn successor(self) -> Self {
Self(self.0.checked_add(2).unwrap())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a comment why we have increments of 2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what the comment on new is for, the idea is to indicate the 'last morsel with this sequence id' using the final bit, so the sequence 1, 2, 3, 3, 3, 4 can become 2, 4, 6, 6, 7, 8 and as soon as we see 7 we know there won't be any 6s or 7s anymore.

py-polars/Cargo.toml Show resolved Hide resolved
@ritchie46 ritchie46 enabled auto-merge (squash) June 24, 2024 11:12
@ritchie46 ritchie46 disabled auto-merge June 24, 2024 11:16
@ritchie46 ritchie46 merged commit c8166a8 into pola-rs:main Jun 24, 2024
20 of 24 checks passed
@stinodego stinodego changed the title perf: parallel linearize in new streaming engine refactor: Parallel linearize in new streaming engine Jun 28, 2024
@stinodego stinodego removed the performance Performance issues or improvements label Jun 28, 2024
@github-actions github-actions bot added the internal An internal refactor or improvement label Jun 28, 2024
@stinodego stinodego changed the title refactor: Parallel linearize in new streaming engine refactor(rust): Parallel linearize in new streaming engine Jun 28, 2024
@stinodego stinodego removed the python Related to Python Polars label Jun 28, 2024
@c-peters c-peters added the accepted Ready for implementation label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants