feat: Expose binary_elementwise_into_string_amortized for plugin authors, recommend apply_into_string_amortized
instead of apply_to_buffer
#17903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things:
binary_elementwise_into_string_amortized
as a utility for plugin authors (and it may end up being useful internally if the great expressification continues?) - there's a a few plugins that have binary operations which produce strings which could benefit from thisapply_to_buffer
and recommendapply_into_string_amortized
to plugin authors instead - their perf is about the same, but the latter has the advantage that the input isn't required to be exactlyStringChunked