Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose binary_elementwise_into_string_amortized for plugin authors, recommend apply_into_string_amortized instead of apply_to_buffer #17903

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Jul 27, 2024

This does a couple of things:

  • add binary_elementwise_into_string_amortized as a utility for plugin authors (and it may end up being useful internally if the great expressification continues?) - there's a a few plugins that have binary operations which produce strings which could benefit from this
  • remove apply_to_buffer and recommend apply_into_string_amortized to plugin authors instead - their perf is about the same, but the latter has the advantage that the input isn't required to be exactly StringChunked

@MarcoGorelli MarcoGorelli changed the title feat: expose binary_elementwise_into_string_amortized for plugin authors, recommend apply_into_string_amortized instead of apply_to_buffer feat: Expose binary_elementwise_into_string_amortized for plugin authors, recommend apply_into_string_amortized instead of apply_to_buffer Jul 27, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jul 27, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 27, 2024 10:12
@ritchie46 ritchie46 merged commit 5fc791c into pola-rs:main Jul 27, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants