fix(python): Fix next on group by objects throw TypeError
#19615
+57
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerriccio33
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19615 +/- ##
=======================================
Coverage 79.96% 79.97%
=======================================
Files 1536 1536
Lines 211374 211389 +15
Branches 2445 2445
=======================================
+ Hits 169034 169052 +18
+ Misses 41785 41782 -3
Partials 555 555 ☔ View full report in Codecov by Sentry. |
ritchie46
requested changes
Nov 4, 2024
| @@ -111,7 +111,13 @@ def __iter__(self) -> Self: | |||
| return self | |||
|
|
|||
| def __next__(self) -> tuple[tuple[object, ...], DataFrame]: | |||
| if self._current_index >= len(self._group_indices): | |||
| try: | |||
There was a problem hiding this comment.
Instead of this try-except, we should return an object of a new class on __iter__. Then it is solved by the type system.
…ice or with streaming collect (pola-rs#19609)
…offsetting by non-constant durations in the timezone-naive case (pola-rs#19616)
…la-rs#19588) Co-authored-by: siddharthv <[email protected]>
…e "$" character with reference to capture groups (vs use as a literal) (pola-rs#19529)
…olumn name matches upper column name (pola-rs#19638)
…la-rs#19667) Co-authored-by: Max Tilley <[email protected]>
…s#19620) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stijn de Gooijer <[email protected]>
pola-rs#19687) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…`, `removesuffix`, and `zfill` in `map_elements` (pola-rs#19672)
…s on `DataFrame` (pola-rs#19683)
tylerriccio33
requested review from
wence-,
orlp and
coastalwhite
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12868 , a direct call to the next method on a group by object raises an unintended AttributeError. In my pr, this raises a TypeError. For my fix, I caught the line throwing the error and re-raised it as a TypeError, since the line indicates the iter method has not been called yet. This fix feels a bit imperfect, and I'm not thrilled the try-except is performed every time the next method is called.
Pretty new to open source, so apologies if things are out of sorts. Thank you!