fix: Add strict parameter to rename_fields #19646
Open
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmudsudo
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
| >>> s = s.struct.rename_fields(["c", "d"]) | ||
| >>> s.struct.fields | ||
| ['c', 'd'] | ||
| >>> s.struct.rename_fields(["c", "d"], strict=True) |
There was a problem hiding this comment.
I reckon the example would be more informative if you:
- show the error you get if you try to rename but provide the wrong number of names with
strict=True; - show what happens if you try to rename but provide the wrong number of names with
strict=False; - both of the above
| @@ -332,7 +336,7 @@ def with_fields( | |||
| │ 1.0 ┆ 4 ┆ 40 ┆ 10 │ | |||
| │ 2.0 ┆ 9 ┆ 18 ┆ 2 │ | |||
| │ 3.0 ┆ 16 ┆ 48 ┆ 3 │ | |||
| └─────┴─────┴───────┴──────────┘ | |||
| └─────┴─────┴──���────┴───���──────┘ | |||
There was a problem hiding this comment.
Funky formatting happening here 😬
| @@ -214,7 +216,7 @@ def rename_fields(self, names: Sequence[str]) -> Expr: | |||
| │ struct_col │ | |||
| │ --- │ | |||
| │ struct[4] │ | |||
| ╞══════════════════════╡ | |||
| ╞══════��═══════════════╡ | |||
There was a problem hiding this comment.
Funky formatting happening here 😬
rodrigogiraoserrao
changed the title
github-actions
bot
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19132