Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Streamline internal SQL join condition processing #19658

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Nov 6, 2024

Improved SQL "JOIN ON" constraint resolution; there was a lot of redundant code in process_join_constraint - now delegates properly to process_join_on, noticeably streamlining it (and making it easier to integrate future join updates).

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Nov 6, 2024
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (6b0a906) to head (b217680).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-sql/src/context.rs 92.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19658   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files        1537     1537           
  Lines      211923   211899   -24     
  Branches     2446     2446           
=======================================
- Hits       169249   169240    -9     
+ Misses      42120    42105   -15     
  Partials      554      554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a186f12 into pola-rs:main Nov 6, 2024
32 checks passed
@alexander-beedie alexander-beedie deleted the sql-streamline-join-constraints branch November 6, 2024 14:10
tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants