fix(python): Release the GIL in Python APIs, part 2 of 2 #19762
Merged
+259
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamarst
commented
Nov 13, 2024
| for i in invalid_indices { | ||
| validity.set(i, false); | ||
| pub fn to_struct(&self, py: Python, name: &str, invalid_indices: Vec<usize>) -> PySeries { | ||
| py.allow_threads(|| { |
There was a problem hiding this comment.
Same code, just indented.
itamarst
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19762 +/- ##
=======================================
Coverage 79.55% 79.55%
=======================================
Files 1544 1544
Lines 213240 213325 +85
Branches 2441 2441
=======================================
+ Hits 169643 169720 +77
- Misses 43048 43056 +8
Partials 549 549 ☔ View full report in Codecov by Sentry. |
|
Can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19382
This (hopefully) covers the rest of the APIs. I skipped APIs that seemed immediate, and so I may have missed some, but hopefully coverage is significantly better.
There should be no other meaningful code changes, just GIL releasing.