Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect filter after right-join on LazyFrame #19775

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #19772

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.55%. Comparing base (420c0d9) to head (a1a06c6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lan/src/plans/optimizer/predicate_pushdown/join.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19775   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files        1544     1544           
  Lines      213240   213243    +3     
  Branches     2441     2441           
=======================================
+ Hits       169645   169648    +3     
  Misses      43046    43046           
  Partials      549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

match how {
JoinType::Left => LeftRight(false, true),
JoinType::Full { .. } | JoinType::Cross => LeftRight(true, true),
_ => LeftRight(false, false),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we forgot to update this function when we added Right join, and it silently passed because of the _ => catch-all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't silently catch all. :|

@nameexhaustion nameexhaustion marked this pull request as ready for review November 14, 2024 10:50
@ritchie46 ritchie46 merged commit 1e262ba into pola-rs:main Nov 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy/Eager right-join is giving different results
2 participants