Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Use HashKeys abstraction #19785

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Nov 14, 2024

This will be used in both the join / reduce interfaces to abstract over a key dataframe which may or may not be pre-hashed.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 1.08696% with 91 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (8cb7839) to head (ff2bbe6).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/hash_keys.rs 0.00% 76 Missing ⚠️
crates/polars-expr/src/groups/row_encoded.rs 0.00% 8 Missing ⚠️
crates/polars-stream/src/nodes/group_by.rs 0.00% 5 Missing ⚠️
crates/polars-expr/src/groups/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19785      +/-   ##
==========================================
- Coverage   79.55%   79.53%   -0.02%     
==========================================
  Files        1544     1546       +2     
  Lines      213240   213498     +258     
  Branches     2441     2442       +1     
==========================================
+ Hits       169643   169809     +166     
- Misses      43048    43139      +91     
- Partials      549      550       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant