-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust,python): Add config to specify GPU polars as the default engine #20717
base: main
Are you sure you want to change the base?
Conversation
Wouldn't it be more practical if you can set any engine then as default? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20717 +/- ##
==========================================
- Coverage 79.64% 79.63% -0.01%
==========================================
Files 1571 1567 -4
Lines 223186 223060 -126
Branches 2554 2554
==========================================
- Hits 177751 177638 -113
+ Misses 44850 44837 -13
Partials 585 585 ☔ View full report in Codecov by Sentry. |
I think this isn't as simple as it seems, because we do also call Polars methods in the Python code internally which are only supported on, for example, the eager engine. |
…-gpu-default-engine
Can you expand on what you mean here? Effectively what this is trying to do is add a global config option for the default value in Why would hooking this up via a config option not work? |
@wence- I have no idea what the full scope of such examples are throughout the codebase, but one example is |
OK, thanks, I think I see. I think there's some amount of tension here between making this "easy" to configure globally and I guess some things breaking at a distance from where the user might expect. |
Ok tests are passing now. Gentle ping for reviews from @ritchie46 @orlp et al |
Apart of #19797. We should also follow up the PR to allow other engines to be the default.