fix(boot) refactoring DDR/startup broke AMP

Fixing a regresson AMP booting by ensuring that all Harts are checked for booting when restarting by bitmask. Signed-off-by: Ivan Griffin <[email protected]>
polarfire-soc · Feb 26, 2024 · b573459 · b573459
1 parent e0b171c
commit b573459
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/services/boot/hss_boot_service.c b/services/boot/hss_boot_service.c
@@ -877,9 +877,11 @@ enum IPIStatusCode HSS_Boot_RestartCores_Using_Bitmask(union HSSHartBitmask rest
         mHSS_DEBUG_PRINTF(LOG_ERROR, "validation failed for Hart bitmask %x\n", restartHartBitmask.uint);
     } else {
         for (unsigned int source = HSS_HART_U54_1;
-             (source < HSS_HART_NUM_PEERS) && (restartHartBitmask.uint & (unsigned int)BIT(source)); source++) {
+             (source < HSS_HART_NUM_PEERS); source++) {
             union HSSHartBitmask localRestartHartBitmask = { .uint = 0u };
 
+            if (!(restartHartBitmask.uint & (unsigned int)BIT(source))) { continue; }
+
             // in interrupts-always-enabled world of the HSS, it would appear less
             // racey to boot secondary cores first and have them all wait...
             for (unsigned int i = 0u; i < ARRAY_SIZE(bootMachine); i++) {