-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SDK stable2409
#490
base: main
Are you sure you want to change the base?
Update to SDK stable2409
#490
Conversation
2e8844d
to
471ce8d
Compare
stable2409
stable2409
f08d159
to
4b4a252
Compare
- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (#4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights
- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (SDK #4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights
- [Assets] Call implementation for `transfer_all` (SDK #4527) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488) - relax XcmFeeToAccount trait bound on AccountId (SDK #4959)
- [Assets] Call implementation for `transfer_all` (SDK #4527) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488) - relax XcmFeeToAccount trait bound on AccountId (SDK #4959)
- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - [bh polkadot] minor: replace `DOLLARS` with `UNITS` on `BridgeDeposit` storage type
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
3d0b758
to
e0760ad
Compare
I can probably squeeze it in later this week. 👍 |
Opened for review with a small caveat: tests will keep failing, until #472 is merged and can be merged back to this branch. |
system-parachains/bridge-hubs/bridge-hub-polkadot/primitives/src/lib.rs
Outdated
Show resolved
Hide resolved
// TODO: What's the correct value? | ||
pub storage BridgeDeposit: Balance = constants::currency::UNITS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for testnets I used values related to the HRMP deposits from live testnets, we could use those or add some utility adapter, which would read HRMP deposit from HostConfiguration
// TODO: What's the correct value? | |
pub storage BridgeDeposit: Balance = constants::currency::UNITS; | |
// TODO: What's the correct value? - FAIL-CI | |
pub storage BridgeDeposit: Balance = constants::currency::UNITS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question: is there a specific place in runtimes
where I can get the HRMP deposit value? Or somewhere in the testnet (on polkadot-sdk
), maybe?
…ge_pallet_ethereum_client::WeightInfo::submit_with_sync_committee` to assert tests are passing
16a2cf1
to
524efc9
Compare
/cmd bench --runtime bridge-hub-kusama --continue-on-fail |
Command "--runtime bridge-hub-kusama --continue-on-fail" has started 🚀 See logs here |
Command "--runtime bridge-hub-kusama --continue-on-fail" has failed ❌! See logs here |
The Rococo/Westend testnets are bridged to Ethereum Sepolia testnet which is using But Ethereum |
system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
use bp_bridge_hub_polkadot::snowbridge::{CreateAssetCall, InboundQueuePalletInstance, Parameters}; | ||
pub use bp_bridge_hub_polkadot::snowbridge::{EthereumLocation, EthereumNetwork}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yrong @alistair-singh @vgeddes I have compared the PNA runtime changes required and all looks correct, from what I can see. Please double check :)
...-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/snowbridge_pallet_ethereum_client.rs
Outdated
Show resolved
Hide resolved
system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
@pandres95 I added the Snowbridge Polkadot-native token transfer to Ethereum integration tests here: pandres95#2 @acatangiu we need to set the ReserveAssetDeposited weight in PBH to something realistic for PNA to work. |
why? where would BridgeHub receive/execute a |
* adds pna tests * clippy
… Sepolia testnet, and use mainnet instead.
Our EthereumBlobExporter expects a message that contains |
* fix test * revert weight
AFAIK, the XCM is weighed as a first step of execution. If BridgeHub is not executing the XCM, why would it weigh it? I was expecting the XCM is captured, parsed and consumed by the Snowbridge exporter before being weighed or executed. |
@acatangiu you are right, its not the weight that is a problem. It is related to withdrawing the fee asset it seems:
|
@pandres95 @acatangiu test fixes over here: pandres95#4 Thanks @alistair-singh for the |
@acatangiu @bkontur any clue about this error? https://github.com/polkadot-fellows/runtimes/actions/runs/11574125246/job/32217719672#step:11:244 |
system-parachains/bridge-hubs/bridge-hub-polkadot/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
system-parachains/bridge-hubs/bridge-hub-polkadot/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
system-parachains/bridge-hubs/bridge-hub-polkadot/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
system-parachains/bridge-hubs/bridge-hub-polkadot/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
system-parachains/bridge-hubs/bridge-hub-polkadot/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
system-parachains/bridge-hubs/bridge-hub-polkadot/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
I think it should be related to the frame-omni-bencher bug, let me check that and try it tomorrow |
Closes #457
Closes #469
Updating the runtimes to SDK version
stable2409
. CHANGELOG mentions all relevant changes for UI and Walletbuilders.Checklist
stable2409
Dependencies
This PR depends on certain PRs to be merged before it can properly work.
Impacts
The success of this PR impacts directly on the feasibility of executing certain issues, or closing certain PRs.
Help wanted
Initially, I request the help of:
XCMv4
.Lanes
toLegacyLane
-based lanes storage).