Update to SDK `stable2409` #490

pandres95 · 2024-10-19T17:06:02Z

Closes #457
Closes #469

Updating the runtimes to SDK version stable2409. CHANGELOG mentions all relevant changes for UI and Walletbuilders.

Checklist

Update SDK to stable2409
Update configuration for relay chains.
Update configuration for system parachains.
Update configuration for emulated chains.
Update configuration for Encointer (see Help wanted).
Update CHANGELOG.

Dependencies

This PR depends on certain PRs to be merged before it can properly work.

Update foreign asset ids from v3 to v4 #472

Impacts

The success of this PR impacts directly on the feasibility of executing certain issues, or closing certain PRs.

Help wanted

Initially, I request the help of:

@franciscoaguirre to help me correcting the potential conflicts that may arise when foreign assets change to XCMv4.
@acatangiu to help me setting up the Bridge Hubs, as well as adding the respective transition layer (a.k.a. preparing the migrations from fixed Lanes to LegacyLane-based lanes storage).
@clangenb to help me upgrading Encointer.
@Szegoo to check the parameters that changed in Coretime.

- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (#4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights

- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (SDK #4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights

- [Assets] Call implementation for `transfer_all` (SDK #4527) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488) - relax XcmFeeToAccount trait bound on AccountId (SDK #4959)

- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount`

- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - [bh polkadot] minor: replace `DOLLARS` with `UNITS` on `BridgeDeposit` storage type

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

- add possibility to inject non-authorities session-keys in genesis (SDK #5078)

clangenb · 2024-10-21T07:38:52Z

I can probably squeeze it in later this week. 👍

pandres95 · 2024-10-21T07:38:53Z

Opened for review with a small caveat: tests will keep failing, until #472 is merged and can be merged back to this branch.

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

system-parachains/bridge-hubs/bridge-hub-polkadot/primitives/src/lib.rs

bkontur · 2024-10-21T07:38:37Z

system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs

+	// TODO: What's the correct value?
+	pub storage BridgeDeposit: Balance = constants::currency::UNITS;


for testnets I used values related to the HRMP deposits from live testnets, we could use those or add some utility adapter, which would read HRMP deposit from HostConfiguration

Suggested change

// TODO: What's the correct value?

pub storage BridgeDeposit: Balance = constants::currency::UNITS;

// TODO: What's the correct value? - FAIL-CI

pub storage BridgeDeposit: Balance = constants::currency::UNITS;

I have a question: is there a specific place in runtimes where I can get the HRMP deposit value? Or somewhere in the testnet (on polkadot-sdk), maybe?

…ge_pallet_ethereum_client::WeightInfo::submit_with_sync_committee` to assert tests are passing

pandres95 · 2024-10-26T19:07:57Z

/cmd bench --runtime bridge-hub-kusama --continue-on-fail

github-actions · 2024-10-26T19:35:11Z

Command "--runtime bridge-hub-kusama --continue-on-fail" has started 🚀 See logs here

github-actions · 2024-10-26T19:35:25Z

Command "--runtime bridge-hub-kusama --continue-on-fail" has failed ❌! See logs here

acatangiu · 2024-10-28T08:12:29Z

@acatangiu I found that in kah integration tests, the chain 11155111 is being used as the origin chain for wETH. So, I made this change: https://github.com/pandres95/runtimes/blob/f8adb35e0efda35c96b5e3913e60f7f201aecfcb/system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs#L516-L521

Is this alright? Or should we change that value in the tests and point to the chain 1?

The Rococo/Westend testnets are bridged to Ethereum Sepolia testnet which is using chain_id = 11155111.

But Ethereum chain_id should be 1 throughout this repo, as that's Ethereum Mainnet which Polkadot is bridged to.

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs

claravanstaden · 2024-10-28T08:48:26Z

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs

 use bp_bridge_hub_polkadot::snowbridge::{CreateAssetCall, InboundQueuePalletInstance, Parameters};
+pub use bp_bridge_hub_polkadot::snowbridge::{EthereumLocation, EthereumNetwork};


@yrong @alistair-singh @vgeddes I have compared the PNA runtime changes required and all looks correct, from what I can see. Please double check :)

...-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/snowbridge_pallet_ethereum_client.rs

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs

claravanstaden · 2024-10-28T10:26:28Z

@pandres95 I added the Snowbridge Polkadot-native token transfer to Ethereum integration tests here: pandres95#2

@acatangiu we need to set the ReserveAssetDeposited weight in PBH to something realistic for PNA to work.

acatangiu · 2024-10-28T12:18:33Z

@acatangiu we need to set the ReserveAssetDeposited weight in PBH to something realistic for PNA to work.

why? where would BridgeHub receive/execute a ReserveAssetDeposited from? BH only handles DOT which cannot be transferred into BH as a reserve transfer with a remote reserve.

* adds pna tests * clippy

… Sepolia testnet, and use mainnet instead.

claravanstaden · 2024-10-28T18:15:13Z

why? where would BridgeHub receive/execute a ReserveAssetDeposited from? BH only handles DOT which cannot be transferred into BH as a reserve transfer with a remote reserve.

Our EthereumBlobExporter expects a message that contains ReserveAssetDeposited. The exporter then parses the xcm payload to send a command to Ethereum. So it does not actually execute ReserveAssetDeposited with the XCM executor, but I think the message is still weighed per instruction.

* fix test * revert weight

acatangiu · 2024-10-29T08:58:36Z

Our EthereumBlobExporter expects a message that contains ReserveAssetDeposited. The exporter then parses the xcm payload to send a command to Ethereum. So it does not actually execute ReserveAssetDeposited with the XCM executor, but I think the message is still weighed per instruction.

AFAIK, the XCM is weighed as a first step of execution. If BridgeHub is not executing the XCM, why would it weigh it?

I was expecting the XCM is captured, parsed and consumed by the Snowbridge exporter before being weighed or executed. ~~Ideally it should be captured even before trying to go through the BH XCM barriers, but I'm not sure about that, needs checking.~~ L.E.: barriers are used during execution, so they should also not be a problem.

claravanstaden · 2024-10-29T10:30:05Z

@acatangiu you are right, its not the weight that is a problem. It is related to withdrawing the fee asset it seems:

2024-10-29T10:24:55.407179Z TRACE xcm::bridge-hub-router: Router with bridged_network_id Kusama does not support bridging to network Ethereum { chain_id: 1 }!    
2024-10-29T10:24:55.407185Z TRACE xcm::bridge-hub-router: validate - ViaBridgeHubExporter - error: NotApplicable    
2024-10-29T10:24:55.407318Z TRACE xcm::pallet_xcm::note_unknown_version: XCM version is unknown for destination: Location { parents: 1, interior: X1([Parachain(1002)]) }    
2024-10-29T10:24:55.407504Z TRACE xcm::contains: AllSiblingSystemParachains location: Location { parents: 0, interior: X1([AccountId32 { network: Some(Polkadot), id: [212, 53, 147, 199, 21, 253, 211, 28, 97, 20, 26, 189, 4, 169, 159, 214, 130, 44, 133, 88, 133, 76, 205, 227, 154, 86, 132, 231, 165, 109, 162, 125] }]) }    
2024-10-29T10:24:55.408142Z TRACE xcm::fungible_adapter: withdraw_asset what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(340282366920938463463374607431768211455) }, who: Location { parents: 0, interior: X1([AccountId32 { network: Some(Polkadot), id: [212, 53, 147, 199, 21, 253, 211, 28, 97, 20, 26, 189, 4, 169, 159, 214, 130, 44, 133, 88, 133, 76, 205, 227, 154, 86, 132, 231, 165, 109, 162, 125] }]) }

claravanstaden · 2024-10-29T12:41:42Z

@pandres95 @acatangiu test fixes over here: pandres95#4 Thanks @alistair-singh for the BridgeHubEthereumBaseFee tip, you were right. 🏆

pandres95 · 2024-10-29T14:45:35Z

@acatangiu @bkontur any clue about this error?

https://github.com/polkadot-fellows/runtimes/actions/runs/11574125246/job/32217719672#step:11:244

system-parachains/bridge-hubs/bridge-hub-polkadot/tests/snowbridge.rs

bkontur · 2024-10-29T15:29:22Z

@acatangiu @bkontur any clue about this error?

https://github.com/polkadot-fellows/runtimes/actions/runs/11574125246/job/32217719672#step:11:244

I think it should be related to the frame-omni-bencher bug, let me check that and try it tomorrow

chore(Cargo): update SDK to stable2409

8066fc1

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 2e8844d to 471ce8d Compare October 19, 2024 17:06

pandres95 changed the title ~~Upgrade to Polkadot SDK stable2409~~ Update to Polkadot SDK stable2409 Oct 19, 2024

pandres95 changed the title ~~Update to Polkadot SDK stable2409~~ Update to SDK stable2409 Oct 19, 2024

pandres95 mentioned this pull request Oct 20, 2024

Migrate all existing foreign assets to XCMv4. #209

Open

pandres95 force-pushed the upgrade-polkadot-stable2409 branch 3 times, most recently from f08d159 to 4b4a252 Compare October 21, 2024 02:23

pandres95 added 13 commits October 20, 2024 21:37

wip(workspace): disable Encointer

0450dd2

feat(system-parachains/collectives): Configure Collectives Polkadot

161bfaf

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

feat(system-parachains/coretime): Configure Coretime Kusama

4ec6e3a

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

feat(system-parachains/coretime): Configure Coretime Polkadot

44d41a9

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

feat(system-parachains/people): Configure People Kusama

1e0e946

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

feat(system-parachains/people): Configure People Polkadot

62af401

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

change(integration-tests/emulated): Configure Penpal

e0760ad

- add possibility to inject non-authorities session-keys in genesis (SDK #5078)

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 3d0b758 to e0760ad Compare October 21, 2024 02:45

pandres95 added 3 commits October 21, 2024 02:36

change(system-parachains): adjust tests + minor fixes

715531f

change(integration-tests): minor adjustments

457dab3

fix(relay): missing BenchmarkHelper for pallet_mmr

f2a3fce

pandres95 marked this pull request as ready for review October 21, 2024 07:38

fix(relay/kusama): missing feature propagation

fd15642

bkontur reviewed Oct 21, 2024

View reviewed changes

wip(bridge-hubs/bridge-hub-polkadot): decrease refTime in `snowbrid…

524efc9

…ge_pallet_ethereum_client::WeightInfo::submit_with_sync_committee` to assert tests are passing

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 16a2cf1 to 524efc9 Compare October 26, 2024 19:05

claravanstaden reviewed Oct 28, 2024

View reviewed changes

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs Outdated Show resolved Hide resolved

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs Outdated Show resolved Hide resolved

claravanstaden reviewed Oct 28, 2024

View reviewed changes

...-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/snowbridge_pallet_ethereum_client.rs Outdated Show resolved Hide resolved

claravanstaden reviewed Oct 28, 2024

View reviewed changes

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs Outdated Show resolved Hide resolved

claravanstaden and others added 3 commits October 28, 2024 08:00

Snowbridge - Transfer native token to Ethereum tests (#2)

595ce90

* adds pna tests * clippy

change(integration-tests/asset-hub-kusama): remove test references to…

93fb88b

… Sepolia testnet, and use mainnet instead.

fix: make clippy happy

ae42f9c

Fix Snowbridge test resulting in overweight block (#3)

f5e70b0

* fix test * revert weight

fix pna tests (#4)

62cfc40

pandres95 commented Oct 29, 2024

View reviewed changes

pandres95 added 6 commits October 29, 2024 10:04

make clippy happy 1/4

6e1bf6d

make clippy happy 2/4

f42fd5b

make clippy happy 3/4

5f494c5

make clippy happy 4/6

6e50ffa

make clippy happy 5/6

8d8a2d9

make clippy happy 6/6

e9b5c24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to SDK `stable2409` #490

Update to SDK `stable2409` #490

pandres95 commented Oct 19, 2024 •

edited

Loading

clangenb commented Oct 21, 2024

pandres95 commented Oct 21, 2024

bkontur Oct 21, 2024

pandres95 Oct 23, 2024

pandres95 commented Oct 26, 2024

github-actions bot commented Oct 26, 2024

github-actions bot commented Oct 26, 2024

acatangiu commented Oct 28, 2024

claravanstaden Oct 28, 2024

claravanstaden commented Oct 28, 2024

acatangiu commented Oct 28, 2024

claravanstaden commented Oct 28, 2024

acatangiu commented Oct 29, 2024 •

edited

Loading

claravanstaden commented Oct 29, 2024 •

edited

Loading

claravanstaden commented Oct 29, 2024

pandres95 commented Oct 29, 2024

bkontur commented Oct 29, 2024

		// TODO: What's the correct value?
		pub storage BridgeDeposit: Balance = constants::currency::UNITS;

		use bp_bridge_hub_polkadot::snowbridge::{CreateAssetCall, InboundQueuePalletInstance, Parameters};
		pub use bp_bridge_hub_polkadot::snowbridge::{EthereumLocation, EthereumNetwork};

Update to SDK stable2409 #490

Are you sure you want to change the base?

Update to SDK stable2409 #490

Conversation

pandres95 commented Oct 19, 2024 • edited Loading

Checklist

Dependencies

Impacts

Help wanted

clangenb commented Oct 21, 2024

pandres95 commented Oct 21, 2024

bkontur Oct 21, 2024

Choose a reason for hiding this comment

pandres95 Oct 23, 2024

Choose a reason for hiding this comment

pandres95 commented Oct 26, 2024

github-actions bot commented Oct 26, 2024

github-actions bot commented Oct 26, 2024

acatangiu commented Oct 28, 2024

claravanstaden Oct 28, 2024

Choose a reason for hiding this comment

claravanstaden commented Oct 28, 2024

acatangiu commented Oct 28, 2024

claravanstaden commented Oct 28, 2024

acatangiu commented Oct 29, 2024 • edited Loading

claravanstaden commented Oct 29, 2024 • edited Loading

claravanstaden commented Oct 29, 2024

pandres95 commented Oct 29, 2024

bkontur commented Oct 29, 2024

Update to SDK `stable2409` #490

Update to SDK `stable2409` #490

pandres95 commented Oct 19, 2024 •

edited

Loading

acatangiu commented Oct 29, 2024 •

edited

Loading

claravanstaden commented Oct 29, 2024 •

edited

Loading