Mocklibc subproject fixes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the port to Meson, mocklibc is pulled in as a Meson subproject. As the local copy is now unused, it is best to remove it.
mbiebl
force-pushed
the
mocklibc-subproject
branch
from
f40844f
to
3356ea8
Compare
|
Will fix #182 |
…diff_files The local copy of mocklibc was changed in 63ee649 5b8cd1a 0d78d1e Turn those into patches and apply them via the diff_files mechanism. This requires Meson 0.63.0, so bump the version accordingly. https://mesonbuild.com/Wrap-dependency-system-manual.html#diff-files
mbiebl
force-pushed
the
mocklibc-subproject
branch
from
3356ea8
to
4e7cd50
Compare
|
@jrybar-rh this will raise the minimum required meson version to 0.63.0. /me is looking at https://github.com/polkit-org/polkit/actions/runs/8310088174/job/22742181725 |
|
Another alternative could be, to create a PPA with a meson backport or use one of the existing ones at |
Brunojoes69
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn local modifications of mocklibc into patches and apply them via diff_files
The local copy of mocklibc was changed in
63ee649
5b8cd1a
0d78d1e
Turn those into patches and apply them via the diff_files mechanism.
This requires Meson 0.63.0, so bump the version accordingly.
https://mesonbuild.com/Wrap-dependency-system-manual.html#diff-files
Follow-up/Fix for #428