Refactor config.h #454
Merged
Refactor config.h #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
Closed
notpeelz
force-pushed
the
refactor-config-h
branch
from
7c7e724
to
e2a72aa
Compare
mrc0mmand
approved these changes
Jun 11, 2024
Merged
notpeelz
force-pushed
the
refactor-config-h
branch
from
e2a72aa
to
30937fa
Compare
notpeelz
force-pushed
the
refactor-config-h
branch
from
30937fa
to
2431609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplified the handling of
config.h.Instead of having
#include "config.h"in every file, we can use the compiler's-includeoption to do that for us.I had to bump the meson version requirement to >=1.4.0 to use the
file.full_path()API.