ci: do nightly polkit builds & submit them to Coverity #523
+98
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evverx
reviewed
Nov 6, 2024
.github/workflows/coverity.sh
Outdated
| results_archive="analysis-results.tgz" | ||
| sha=$(git rev-parse --short HEAD) | ||
|
|
||
| meson setup build -Dtests=true -Dexamples=true |
There was a problem hiding this comment.
I think it would be great to turn on as many features as possible to cover things like #486 as well. On the other hand the default configuration is more important probably. I'm not sure.
There was a problem hiding this comment.
Good point. I went through the available options and thought I enabled all that could be relevant for Coverity (and that are not enabled by default), but I apparently missed some :)
Let's reintroduce regular Coverity builds. Since there's a pretty strict rate limit [0], do one nightly build each day, and upload it to Coverity for analysis. The results can be then found in the project dashboard [1]. [0] https://scan.coverity.com/faq#frequency [1] https://scan.coverity.com/projects/polkit?tab=overview Resolves: #517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I created this PR's branch intentionally directly in the upstream repo, so it has access to the repo secrets with the Coverity token, as PRs from forks can't do that.
Let's reintroduce regular Coverity builds. Since there's a pretty strict rate limit [0], do one nightly build each day, and upload it to Coverity for analysis. The results can be then found in the project dashboard [1].
[0] https://scan.coverity.com/faq#frequency
[1] https://scan.coverity.com/projects/polkit?tab=overview
Resolves: #517