Extend bricks to test calculation #527
Conversation
| #{})] | ||
| included-bricks (common/brick-names-to-test test eligible-bricks) | ||
| user-selected-bricks (if user-selected-bricks (set user-selected-bricks) eligible-bricks) | ||
| selected-bricks (if include-project |
There was a problem hiding this comment.
If the user doesn't add brick:foo or project:bar this function (bricks-to-test) will return (directly or indirectly) changed bricks, which we want to test. I think it's a bit misleading to change from changed-bricks to selected-bricks here, for that reason.
I understand why you did the other change from selected-bricks to user-selected-bricks. But I would prefer to keep the name selected-bricks. The reason is that it's called that everywhere else in the call chain. We also have selected-projects. I think that can keep its name too, otherwise we should rename that to user-selected-projects too.
There was a problem hiding this comment.
Makes sense, I renamed them back.
| (bricks-for-source project %)))) | ||
| (vec)) | ||
| ;; might include bricks that don't have test sources | ||
| :bricks-to-test-2 |
There was a problem hiding this comment.
And yes, we need to come up with a better name. One suggestion is :bricks-to-test-all-sources.
There was a problem hiding this comment.
I like it, thanks!
|
Thank you! |
Adds a new key to
project(bricks-to-test-all-sources) which differs frombricks-to-testin that it might contain bricks that don't have any dedicated test sources.This is to let test runners discover potential tests in src-only bricks as well. (Like Kaocha's automatic spec test generation)
TODO:
Also see #448