remove EasyProcess dependency #47 #48

README.md

@@ -311,7 +311,7 @@ def thread_function(index):
         cmd = ["xmessage", str(index)]
         # disp.new_display_var should be used for new processes
         # disp.env() copies global os.environ and adds disp.new_display_var
-        with EasyProcess(cmd, env=disp.env()) as proc:
+        with EasyProcess(cmd, env=disp.env()):
             img = disp.waitgrab()
             img.save("xmessage{}.png".format(index))
 

pyvirtualdisplay/abstractdisplay.py

@@ -8,8 +8,6 @@
 import time
 from threading import Lock
 
-from easyprocess import EasyProcess, EasyProcessError
-
 from pyvirtualdisplay import xauth
 from pyvirtualdisplay.util import get_helptext, platform_is_osx
 
@@ -244,17 +242,34 @@ def _start1(self):
                 break
 
             try:
-                xdpyinfo = EasyProcess(["xdpyinfo"], env=self._env())
-                xdpyinfo.enable_stdout_log = False
-                xdpyinfo.enable_stderr_log = False
-                exit_code = xdpyinfo.call().return_code
-            except EasyProcessError:
+                xdpyinfo = subprocess.Popen(
+                    ["xdpyinfo"],
+                    env=self._env(),
+                    stdout=subprocess.PIPE,
+                    stderr=subprocess.PIPE,
+                    shell=False,
+                )
+                _, _ = xdpyinfo.communicate()
+                exit_code = xdpyinfo.returncode
+            except FileNotFoundError:
                 log.warning(
                     "xdpyinfo was not found, X start can not be checked! Please install xdpyinfo!"
                 )
                 time.sleep(_X_START_WAIT)  # old method
                 ok = True
                 break
+            # try:
+            #     xdpyinfo = EasyProcess(["xdpyinfo"], env=self._env())
+            #     xdpyinfo.enable_stdout_log = False
+            #     xdpyinfo.enable_stderr_log = False
+            #     exit_code = xdpyinfo.call().return_code
+            # except EasyProcessError:
+            #     log.warning(
+            #         "xdpyinfo was not found, X start can not be checked! Please install xdpyinfo!"
+            #     )
+            #     time.sleep(_X_START_WAIT)  # old method
+            #     ok = True
+            #     break
 
             if exit_code != 0:
                 pass

pyvirtualdisplay/util.py

@@ -1,14 +1,24 @@
+import subprocess
 import sys
 
-from easyprocess import EasyProcess
-
 
 def get_helptext(program):
-    p = EasyProcess([program, "-help"])
-    p.enable_stdout_log = False
-    p.enable_stderr_log = False
-    p.call()
-    helptext = p.stderr
+    cmd = [program, "-help"]
+
+    # py3.7+
+    # p = subprocess.run(cmd, capture_output=True)
+    # stderr = p.stderr
+
+    # py3.6 also
+    p = subprocess.Popen(
+        cmd,
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+        shell=False,
+    )
+    _, stderr = p.communicate()
+
+    helptext = stderr.decode("utf-8", "ignore")
     return helptext
 
 

requirements-doc.txt

@@ -9,4 +9,5 @@ vncdotool==0.13.0
 # psutil
 # for travis xenial
 # attrs
-# pytest-xdist
+# pytest-xdist
+EasyProcess

requirements-test.txt

@@ -9,3 +9,4 @@ attrs
 pytest-xdist
 mypy
 flake8
+EasyProcess

setup.py

@@ -38,7 +38,6 @@
     "Programming Language :: Python :: 3.10",
 ]
 
-install_requires = ["EasyProcess"]
 
 setup(
     name=PYPI_NAME,
@@ -53,7 +52,7 @@
     url=URL,
     license="BSD",
     packages=PACKAGES,
-    install_requires=install_requires,
+    # install_requires=install_requires,
     package_data={
         NAME: ["py.typed"],
     },