add urldecode function (opentofu#1234)

Signed-off-by: pooriaghaedi <[email protected]>
pooriaghaedi · Feb 23, 2024 · 7972534 · 7972534
1 parent e566f2b
commit 7972534
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 18 deletions.
diff --git a/internal/lang/funcs/encoding.go b/internal/lang/funcs/encoding.go
@@ -227,7 +227,7 @@ var URLEncodeFunc = function.New(&function.Spec{
 	},
 })
 
-// URLDecodeFunc constructs a function that applies URL decoding to a given string.
+// URLDecodeFunc constructs a function that applies URL decoding to a given encoded string.
 var URLDecodeFunc = function.New(&function.Spec{
 	Params: []function.Parameter{
 		{
@@ -301,7 +301,7 @@ func URLEncode(str cty.Value) (cty.Value, error) {
 	return URLEncodeFunc.Call([]cty.Value{str})
 }
 
-// URLDecode decodes a URL-encoded string.
+// URLDecode decodes a URL encoded string.
 //
 // This function decodes the given string that has been encoded.
 //

diff --git a/internal/lang/funcs/encoding_test.go b/internal/lang/funcs/encoding_test.go
@@ -286,7 +286,7 @@ func TestURLDecode(t *testing.T) {
 		},
 		{
 			cty.StringVal("foo%00, bar!"),
-			cty.StringVal("foo, bar!"),
+			cty.StringVal("foo\x00, bar!"),
 			false,
 		},
 		{
@@ -347,21 +347,6 @@ func TestURLEncodeDecode(t *testing.T) {
 			cty.StringVal("foo/bar"),
 			false,
 		},
-		{
-			cty.StringVal("foo% bar"),
-			cty.UnknownVal(cty.String),
-			true,
-		},
-		{
-			cty.StringVal("foo%2 bar"),
-			cty.UnknownVal(cty.String),
-			true,
-		},
-		{
-			cty.StringVal("%GGfoo%2bar"),
-			cty.UnknownVal(cty.String),
-			true,
-		},
 		{
 			cty.StringVal("foo%00, bar!"),
 			cty.StringVal("foo%00, bar!"),
@@ -372,6 +357,9 @@ func TestURLEncodeDecode(t *testing.T) {
 	for _, test := range tests {
 		t.Run(fmt.Sprintf("url encode decode(%#v)", test.String), func(t *testing.T) {
 			encoded, err := URLEncode(test.String)
+			if err != nil {
+				t.Fatalf("unexpected error: %s", err)
+			}
 			got, err := URLDecode(encoded)
 
 			if test.Err {