Enhance terminal handling and MIME app detection #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important to mention that:
I will still send the PR regarding this in the cosmic-files repository
the functionality is not 100% complete, in developer mode, when we open cosmic-settings and cosmic-files and I change the terminal and try to click on open terminal in cosmic-files, cosmic files will open the terminal that was already selected, so if I am in cosmic-terminal when I open it and switch to warp and click on open in terminal it will open the old terminal and not warp (which was selected) so we still need to implement some function for cosmic-files to get the changes in real time from the cosmic-settings terminal change
but if you close cosmic files and hit cargo run again, it opens the correct terminal (which would be warp).
continuation and correction of the PR #935 and integrated with #936
Both commits have to be approved for both changes to work.
Also, it's not 100% finished yet
as I said, only when we close cosmic files and open it again (in the dev environment), it sees that the terminal has changed and then it works, it's not working as it should (which is in real time)
so I believe we still have to add a feature to cosmic-files specifically to listen for changes in this function we use to change the terminal
I still don't have any idea how to do this
if anyone has, the idea would be appreciated ;)