Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sector sizes #278

Open
wants to merge 6 commits into
base: master_jammy
Choose a base branch
from
Open

Conversation

vjr
Copy link
Contributor

@vjr vjr commented Dec 1, 2021

Addresses #177

Code stolen from #181 mostly.

@vjr vjr marked this pull request as ready for review December 2, 2021 00:37
@vjr vjr changed the title Initial commit to handle sector sizes Handle sector sizes Dec 2, 2021
@vjr
Copy link
Contributor Author

vjr commented Dec 2, 2021

This PR is mainly to enable the elementary OS installer to work with 4k sector disks and goes along with PR elementary/installer#621

@13r0ck
Copy link
Contributor

13r0ck commented Dec 2, 2021

Wasn't this already addressed by #266 and #273 ?

@vjr
Copy link
Contributor Author

vjr commented Dec 2, 2021

Wasn't this already addressed by #266 and #273 ?

Hello @13r0ck those were only partial or interim fixes just to handle sector sizes for checking the minimum required EFI partition size. This PR more fully addresses the issue and based on my rudimentary testing the elementary OS Installer now successful with the 3 main install options, custom, erase install unencrypted and erase install encrypted.

@vjr
Copy link
Contributor Author

vjr commented Dec 10, 2021

Hello s76 folks! @13r0ck @jackpot51

Is there anything you need from me to get this PR moving along?

Again, note that I'm a novice at Rust but will try to address any shortcomings in this PR as far as I can, although please feel free to add commits directly to expedite the process.

Thank you.

CC @davidmhewitt

@AKmatiAK
Copy link

Hi, I also have 4Kn disk and this pull request is important for me too as I can't install pop os on my HDD

@AKmatiAK
Copy link

Wasn't this already addressed by #266 and #273 ?

Looks like these fixes doesn't work, as if I understand well they're already in 22.04, but partition sizes are calculated to be 8 times smaller than in reality on my 4Kn drive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants