Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogNormal DFE for humans #1698

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

clararehmann
Copy link
Contributor

addresses #1484

I used table S3 from Huber et al. 2017 for the parameters and refactored the mu value of the LogNormal distribution to account for DaDi vs. SLiM scaling. I also modified the DFE tests so that they can accept LogNormal distribution arguments (which are strings, not floats).

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (2ccbf88) to head (2fa7069).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1698   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         139      139           
  Lines        4799     4810   +11     
  Branches      470      470           
=======================================
+ Hits         4792     4803   +11     
  Misses          3        3           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrelharp
Copy link
Contributor

Excellent!

@petrelharp petrelharp merged commit d39b579 into popsim-consortium:main Feb 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants