Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

param table edit for PapuansOutOfAfrica_10J19 #1708

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

andrewkern
Copy link
Member

will close #1707

as pointed out in that issue, the docs parameter table for PapuansOutOfAfrica_10J19 was off by two orders of magnitude for two of the migration params.

it used to say:

Migration rate (x10^-4): 31.4 European–East Asian migration rate
Migration rate (x10^-4): 57.2 East Asian–Papuan migration rate

but in the code has:

m_EU_AS = 3.14e-5
m_AS_Papuan = 5.72e-5

this PR fixes this params displayed in the documentation to match the code

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (b410acf) to head (0b8b458).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1708   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         142      142           
  Lines        4863     4863           
  Branches      470      470           
=======================================
  Hits         4856     4856           
  Misses          3        3           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrewkern andrewkern added the docs Improvements to documentation label Mar 5, 2025
@andrewkern andrewkern merged commit e2587cf into popsim-consortium:main Mar 6, 2025
11 checks passed
@andrewkern andrewkern deleted the papuan_param_doc_fix branch March 6, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between web and code values of migration rates for PapuansOutOfAfrica_10J19 model
1 participant