Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist editor #2506

Merged
merged 26 commits into from
Feb 18, 2025
Merged

Playlist editor #2506

merged 26 commits into from
Feb 18, 2025

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Jan 31, 2025

priginally i wanna make it into playlist app but i think there's no enough ram for it

@zxkmm zxkmm marked this pull request as ready for review February 15, 2025 15:30
@gullradriel
Copy link
Member

Insert on empty playlist is crashing.

@zxkmm
Copy link
Contributor Author

zxkmm commented Feb 18, 2025

Insert on empty playlist is crashing.

oh ya sorry. I mistakenly deleted working code when I deleting serial debug code

@zxkmm
Copy link
Contributor Author

zxkmm commented Feb 18, 2025

https://discord.com/channels/719669764804444213/722101917135798312/1341246221418758286

@gullradriel
Copy link
Member

@gullradriel
Copy link
Member

Working as expected, and I didn't find any crash anymore !
If you are OK let's merge this :-)

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to goooooo !

@gullradriel gullradriel merged commit 73f7f84 into portapack-mayhem:next Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants